[FIX] Use explicit ordered multiple inputs#4860
Merged
markotoplak merged 15 commits intobiolab:masterfrom Sep 17, 2021
Merged
Conversation
ales-erjavec
force-pushed
the
explicit-close-signal
branch
3 times, most recently
from
f889680 to
c3ae76f
Compare
Codecov Report
@@ Coverage Diff @@
## master #4860 +/- ##
==========================================
+ Coverage 85.91% 86.38% +0.46%
==========================================
Files 313 304 -9
Lines 65361 61757 -3604
==========================================
- Hits 56157 53347 -2810
+ Misses 9204 8410 -794 |
ales-erjavec
force-pushed
the
explicit-close-signal
branch
2 times, most recently
from
79aedce to
40ad816
Compare
ales-erjavec
force-pushed
the
explicit-close-signal
branch
from
40ad816 to
f46d302
Compare
ales-erjavec
force-pushed
the
explicit-close-signal
branch
from
f46d302 to
2d15ce5
Compare
ales-erjavec
force-pushed
the
explicit-close-signal
branch
6 times, most recently
from
574cc16 to
26eb359
Compare
ales-erjavec
force-pushed
the
explicit-close-signal
branch
from
26eb359 to
ed6c351
Compare
ales-erjavec
force-pushed
the
explicit-close-signal
branch
2 times, most recently
from
1079d59 to
491f0cb
Compare
ales-erjavec
force-pushed
the
explicit-close-signal
branch
from
491f0cb to
f0c9a5a
Compare
ales-erjavec
force-pushed
the
explicit-close-signal
branch
from
f0c9a5a to
54bb2b8
Compare
ales-erjavec
force-pushed
the
explicit-close-signal
branch
2 times, most recently
from
d6defd7 to
6ff25d3
Compare
ales-erjavec
changed the title
Member
|
/rebase |
Member
|
@ales-erjavec, thanks a lot for this PR. Could you please rebase to master? If I rebase naively (= remove all code corresponding to summaries) I get crashes in the Venn diagram and then in Test and Score when running the widget. Then I stopped. The crashes seem connected with the automatic summaries. |
ales-erjavec
force-pushed
the
explicit-close-signal
branch
from
6ff25d3 to
21dc35c
Compare
3 tasks
markotoplak
force-pushed
the
explicit-close-signal
branch
2 times, most recently
from
319f4d5 to
b7db2f1
Compare
markotoplak
approved these changes
Jul 1, 2021
Member
markotoplak
left a comment
markotoplak
left a comment
There was a problem hiding this comment.
I think we can merge this as soon as the next version of widget-base is released
markotoplak
added
the
waiting for new dependency version
markotoplak
force-pushed
the
explicit-close-signal
branch
from
b7db2f1 to
72606ab
Compare
markotoplak
force-pushed
the
explicit-close-signal
branch
from
72606ab to
091c35a
Compare
markotoplak
force-pushed
the
explicit-close-signal
branch
from
091c35a to
8b63366
Compare
markotoplak
removed
the
waiting for new dependency version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Ref #4215
Description of changes
Use biolab/orange-widget-base#78 explicitly ordered MultiInput insert/remove handlers for all widget with 'multiple' input.
Includes